This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Remove Entity capture/AiksInspector. #52526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
May 2, 2024
Contributor
|
|
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/engine/52526, due to - The status or check suite Linux linux_arm_host_engine has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
bdero
force-pushed
the
bdero/remove-capture
branch
from
4812e4b to
eb514a0
Compare
Contributor
|
Fixes flutter/flutter#134748 |
Member
Author
|
Up to 1004 lines! |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 3, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 3, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 3, 2024
…147761) flutter/engine@c380e9f...98a800b 2024-05-03 [email protected] [et] Add ios_debug_unopt build config. (flutter/engine#52537) 2024-05-03 [email protected] Roll Skia from df970dcd6cfa to 2eaea0383201 (1 revision) (flutter/engine#52536) 2024-05-03 [email protected] [Impeller] Remove Entity capture/AiksInspector. (flutter/engine#52526) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This was referenced May 8, 2024
auto-submit bot
pushed a commit
that referenced
this pull request
May 8, 2024
reverts #52526 fixes flutter/flutter#147989 That PR has broken playgrounds. It's non essential so we can revert it an bdero can take a look whenever he gets another chance. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves flutter/flutter#134748.
This was a really fun experiment. I learned a lot from it, and it genuinely helped me solve some coverage-related problems, but the reality is it was too little too late -- by the time we had this capture system, we had already solved most of the problems that would have benefitted from this.
It's been a few months since I've used or extended the capabilities of this capture system for something, and I don't have the spare time/energy to give it the love it needs to realize the vision I had for it. I still almost exclusively use a combination of native frame captures and print debugging to solve problems.
RIP in peace.