This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[skwasm] Don't mark the backend texture as mipmapped, since it isn't. #52501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
eyebrowsoffire
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 2, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 2, 2024
…147688) flutter/engine@f56c20c...3087ec1 2024-05-02 [email protected] [skwasm] Don't mark the backend texture as mipmapped, since it isn't. (flutter/engine#52501) 2024-05-01 [email protected] Roll Skia from 36ec16922dad to 81ccf3ab27ee (1 revision) (flutter/engine#52504) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
kjlubick
reviewed
May 2, 2024
| _textureSourceWrapper->getTextureSource(), fInfo.width(), | ||
| fInfo.height()); | ||
| glInfo.fFormat = GL_RGBA8_OES; | ||
| glInfo.fTarget = GL_TEXTURE_2D; |
Contributor
There was a problem hiding this comment.
nit: also remove mipmapped on line 94 to make it more clear that param is not used in this impl
Contributor
Author
There was a problem hiding this comment.
Ah, good idea. Unfortunately this already merged. I'll see about cleaning this up in a followup.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't actually produce mipmaps for any of the textures generated through the
TextureSourceImageGenerator, even if it is requested of us. So we shouldn't mark the texture as mipmapped in this case. This will allow rendering mechanisms to fall back to a non-mipmapped rendering strategy as needed.