This repository was archived by the owner on Feb 25, 2025. It is now read-only.
I52370 3.22.cp attempt2 #52491
Merged
I52370 3.22.cp attempt2 #52491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er with ArrayDeques (flutter#51494) Inspired by flutter#50767. [As their documentation notes](https://docs.oracle.com/javase/8/docs/api/java/util/ArrayDeque.html), `ArrayDeque`s are generally faster than LinkedList when used as a queue. Fixes flutter/flutter#143721 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
- Destroy ImageReaders on memory trim. - Unset the VirtualDisplay's surface on memory trim. - On resume, recreate ImageReaders. - On resume, do a dumb little dance and then set the VirtualDisplay's surface Fixes: flutter/flutter#146499 Fixes: flutter/flutter#144219 Internal bug: b/335646931 Android Fix: https://googleplex-android-review.git.corp.google.com/c/platform/frameworks/base/+/27015418 Android 15 will include the fix. Unclear if Android 14 will be patched.
Contributor
Author
|
ERROR at //flutter/third_party/boringssl/BUILD.gn:16:34: Duplicate build argument declaration. Trying to figure out if this was related to the CP |
Member
|
I believe it is not related. There is a caching issue with the bots in the try pool. flutter/flutter#147651 |
johnmccutchan
approved these changes
May 1, 2024
itsjustkevin
approved these changes
May 1, 2024
itsjustkevin
added
the
autosubmit
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes [CP] Beta/3.22 Platform view android 14 workaround flutter#147644
Includes #51494 to avoid merge conflicts and have a cleaner merge.
Pre-launch Checklist
///).