This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Remove rasterizerTracingThreshold, checkerboardRasterCacheImages, and checkerboardOffscreenLayers, etc #52446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hixie
force-pushed
the
remove_old_debugging_apis
branch
3 times, most recently
from
6f41e47 to
c83a5c4
Compare
… checkerboardOffscreenLayers
Hixie
force-pushed
the
remove_old_debugging_apis
branch
from
c83a5c4 to
93827f1
Compare
Member
chinmaygarde
left a comment
chinmaygarde
left a comment
There was a problem hiding this comment.
Should this follow the deprecation policy?
Contributor
Author
|
I expect this to not count as a breaking change per the breaking change policy, but it's hard to tell before we try to roll it into the framework, because flutter/tests doesn't support pre-commit testing for the engine repo. |
Member
|
Yeah, I suspect thats why these old APIs have stuck around for so long. Perhaps break these up into separate patches so for each removal. But I'm fine removing everything wholesale as well. |
chinmaygarde
approved these changes
Apr 30, 2024
Contributor
Author
|
downstream: flutter/flutter#147663 |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 2, 2024
…mages, and checkerboardOffscreenLayers, etc (flutter/engine#52446)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 2, 2024
…147699) flutter/engine@7cbef71...bfc6787 2024-05-02 [email protected] Remove rasterizerTracingThreshold, checkerboardRasterCacheImages, and checkerboardOffscreenLayers, etc (flutter/engine#52446) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.