Remove references to goma #52411
Remove references to goma #52411
Conversation
github-actions
bot
added
affects: desktop
platform-macos
platform-fuchsia
e: impeller
labels
|
Out of curiosity, why is goma (I understand this is a tool for speeding up builds of engine) being removed? What are you replacing it with? |
We're shifting to https://github.com/bazelbuild/reclient. Docs for engine developers are here, but (for the time being) they'll only work for Googlers. |
|
This sounds exciting. Does it mean that it's possible in the future non-Google members will be able to set up their own RBE farm? |
In theory, yes. However, in practice this is not likely to be a well-paved path. |
…147537) flutter/engine@399837d...5165c71 2024-04-29 [email protected] Remove references to goma (flutter/engine#52411) 2024-04-29 [email protected] Make SkUnicode explicitly instead of relying on SkParagraph to make it for us (flutter/engine#52086) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
3 participants
This removes goma most places except for the arguments to the
gnscript, which are referenced by recipes. This does not remove goma capabilities from the GN build entirely. That requires changes in the buildroot which have to be staged after this change.