[Impeller] Fix Vulkan validation error on latest MoltenVK. #52332
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Quick fix to unblock macOS playgrounds. @jonahwilliams is this related to the work for 16 bit floats on Vulkan? Even if we are not using it, the SPIRV seems to be declaring the capability and the new validation layers don't seem particularly happy around it. |
|
We enable but don't use the extension, so its probably in the SPIRV headers but hasn't seemed to cause any issues so far. |
chinmaygarde
added
the
autosubmit
…147262) flutter/engine@b686508...303e718 2024-04-23 [email protected] Roll Skia from f9d6a2cf4179 to f09c6745031c (1 revision) (flutter/engine#52334) 2024-04-23 [email protected] [skwasm] Fix sampling options for low filter quality to match CanvasKit. (flutter/engine#52331) 2024-04-23 [email protected] [Impeller] Fix Vulkan validation error on latest MoltenVK. (flutter/engine#52332) 2024-04-23 [email protected] Roll Skia from 21563606e32d to f9d6a2cf4179 (1 revision) (flutter/engine#52330) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2 participants
Fixes flutter/flutter#147254