This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fail run_impeller_golden_tests if LUCI_CONTEXT && !GOLDCTL
#52300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
flutter/flutter#147180 (comment) landed, rebase this now and we can land it? |
matanlurey
added
the
autosubmit
Contributor
|
auto label is removed for flutter/engine/52300, due to - The status or check suite Mac mac_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
matanlurey
force-pushed
the
skia-gold-run-tests-luci-guard
branch
from
2d56984 to
2e4bac9
Compare
gaaclarke
reviewed
Apr 22, 2024
matanlurey
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 23, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 23, 2024
…147205) flutter/engine@62c9f17...f8e373d 2024-04-22 [email protected] [ios_edit_menu]add native edit menu (flutter/engine#50095) 2024-04-22 [email protected] Fail `run_impeller_golden_tests` if `LUCI_CONTEXT && !GOLDCTL` (flutter/engine#52300) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works to prevent future outages like flutter/flutter#147180.
Also added an explicit
--no-skia-goldflag to use when we don't want Skia Gold used, and used it in the one place we decided (in internal chat) it made sense,mac_unopt.json(was added in 67e6328 for validation-layers testing only).