This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix docs for SemanticsAction #52229
Merged
Fix docs for SemanticsAction #52229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chunhtai
reviewed
Apr 18, 2024
lib/ui/semantics.dart
Outdated
| /// - file://./../../lib/ui/semantics/semantics_node.h | ||
| /// > [!Warning] | ||
| /// > When changes are made to this class, the equivalent APIs in | ||
| /// > `lib/ui/semantics/semantics_node.h` and in each of the embedders |
Contributor
There was a problem hiding this comment.
Does this have to be in public doc?
Contributor
There was a problem hiding this comment.
Seems like something we can use // instead
Member
Author
There was a problem hiding this comment.
https://github.com/flutter/engine/pull/19817/files turned it from private to public with this non-existing \warning thingy. I would also prefer keeping this private, but also don't want to flip-flop between the two every four years or so. Should we once and for all (lol) take this out of the public docs?
Contributor
There was a problem hiding this comment.
let's take it out, I missed this part when I reviewed the pr.
12 tasks
goderbauer
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 18, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 18, 2024
…147006) flutter/engine@46ff024...13a6ce4 2024-04-18 [email protected] Roll Skia from dc6df9137614 to 1af1e478ef85 (10 revisions) (flutter/engine#52230) 2024-04-18 [email protected] Fix docs for SemanticsAction (flutter/engine#52229) 2024-04-18 [email protected] Roll Dart SDK from a0caf3de902d to 8d834bbb2163 (1 revision) (flutter/engine#52228) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gilnobrega
pushed a commit
to gilnobrega/flutter
that referenced
this pull request
Apr 22, 2024
…lutter#147006) flutter/engine@46ff024...13a6ce4 2024-04-18 [email protected] Roll Skia from dc6df9137614 to 1af1e478ef85 (10 revisions) (flutter/engine#52230) 2024-04-18 [email protected] Fix docs for SemanticsAction (flutter/engine#52229) 2024-04-18 [email protected] Roll Dart SDK from a0caf3de902d to 8d834bbb2163 (1 revision) (flutter/engine#52228) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old rendering:
This changes uses markdown syntax introduced in dart-archive/markdown@5fab3a7
Fixes flutter/flutter#94494.