[Impeller] dont use half precision constants / Fixes for SPIRV tools roll #52213

jonahwilliams · 2024-04-18T02:01:51Z

See b/335381180

In an upcoming version of SPIRV tools, these constants are being flagged as invalid. Due to some combination of the macros + inlining we're ending up with multiple precision modifiers on the constants:

third_party/flutter_engine/impeller/entity/shaders/radial_gradient_fill.frag: GLSL to SPIRV failed; Compilation error. 0 error(s) and 1 warning(s).
third_party/flutter_engine/impeller/entity/shaders/radial_gradient_fill.frag:14: warning: '' : all default precisions are highp; use precision statements to quiet warning, e.g.:
third_party/flutter_engine/impeller/entity/shaders/radial_gradient_fill.frag:          "precision mediump int; precision highp float;" 
shaderc: internal error: compilation succeeded but failed to optimize: ID '112' decorated with RelaxedPrecision multiple times is not allowed.
  %float_n0_474999994 = OpConstant %float -0.474999994

We don't really benefit from half precision on these, since we're either using them for equality or can cheaply convert to half precision anyway.

flutter-dashboard · 2024-04-18T02:01:53Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

jiahaog · 2024-04-18T05:42:01Z

impeller/entity/shaders/filters/morphology_filter.frag

 // 'FilterContents::MorphType' enum class.
-const float16_t kMorphTypeDilate = 0.0hf;
-const float16_t kMorphTypeErode = 1.0hf;
+const float kMorphTypeDilate = 0.0;


Even with these changes, the duplicate constant error is still showing up:

shaderc: internal error: compilation succeeded but failed to optimize: ID '27' decorated with RelaxedPrecision multiple times is not allowed. %float_0 = OpConstant %float 0

Also, similar changes are needed to:

engine/impeller/entity/shaders/filters/yuv_to_rgb_filter.frag

Lines 16 to 17 in 132d364

const float16_t kBT601LimitedRange = 0.0hf;

const float16_t kBT601FullRange = 1.0hf;

Updated. Sorry, do you mean that even with this change there are still compilation errors?

Yeah that's what I meant. The compiler doesn't like 0 and 1 as constants for this file and yuv_to_rgb_filter.frag.

The latest commit 80579dd fixes the issue 🙂

woot, thanks for helping with this @jiahaog

…IRV tools roll (flutter/engine#52213)

…147023) flutter/engine@6e4a15d...442d14a 2024-04-18 [email protected] [Impeller] dont use half precision constants / Fixes for SPIRV tools roll (flutter/engine#52213) 2024-04-18 [email protected] Roll Skia from edece87ce734 to 8fd4d8eaadc2 (1 revision) (flutter/engine#52238) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…lutter#147023) flutter/engine@6e4a15d...442d14a 2024-04-18 [email protected] [Impeller] dont use half precision constants / Fixes for SPIRV tools roll (flutter/engine#52213) 2024-04-18 [email protected] Roll Skia from edece87ce734 to 8fd4d8eaadc2 (1 revision) (flutter/engine#52238) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

[Impeller] dont use hf precision constants.

0a426ba

github-actions bot added the e: impeller label Apr 18, 2024

jiahaog reviewed Apr 18, 2024

View reviewed changes

jonahwilliams added 2 commits April 17, 2024 22:56

++

d283caf

remove 0 and 1 constants.

80579dd

jonahwilliams changed the title ~~[Impeller] dont use half precision constants.~~ [Impeller] dont use half precision constants / Fixes for SPIRV tools roll Apr 18, 2024

jonahwilliams requested review from chinmaygarde and jiahaog April 18, 2024 22:38

chinmaygarde approved these changes Apr 18, 2024

View reviewed changes

jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 18, 2024

auto-submit bot merged commit 442d14a into flutter:main Apr 18, 2024

engine-flutter-autoroll mentioned this pull request Apr 19, 2024

Roll Flutter Engine from 6e4a15d31769 to 442d14a7e840 (2 revisions) flutter/flutter#147023

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 19, 2024

442d14a7e [Impeller] dont use half precision constants / Fixes for SP…

431d138

…IRV tools roll (flutter/engine#52213)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Impeller] dont use half precision constants / Fixes for SPIRV tools roll #52213

[Impeller] dont use half precision constants / Fixes for SPIRV tools roll #52213

Uh oh!

jonahwilliams commented Apr 18, 2024

Uh oh!

flutter-dashboard bot commented Apr 18, 2024

Uh oh!

jiahaog Apr 18, 2024

Uh oh!

jonahwilliams Apr 18, 2024

Uh oh!

jiahaog Apr 18, 2024

Uh oh!

jiahaog Apr 18, 2024

Uh oh!

jonahwilliams Apr 18, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	const float16_t kBT601LimitedRange = 0.0hf;
	const float16_t kBT601FullRange = 1.0hf;

[Impeller] dont use half precision constants / Fixes for SPIRV tools roll #52213

[Impeller] dont use half precision constants / Fixes for SPIRV tools roll #52213

Uh oh!

Conversation

jonahwilliams commented Apr 18, 2024

Uh oh!

flutter-dashboard bot commented Apr 18, 2024

Uh oh!

jiahaog Apr 18, 2024

Choose a reason for hiding this comment

Uh oh!

jonahwilliams Apr 18, 2024

Choose a reason for hiding this comment

Uh oh!

jiahaog Apr 18, 2024

Choose a reason for hiding this comment

Uh oh!

jiahaog Apr 18, 2024

Choose a reason for hiding this comment

Uh oh!

jonahwilliams Apr 18, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants