This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[fuchsia] route fuchsia.sysmem2.Allocator #52187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dustingreen
force-pushed
the
route_sysmem2
branch
7 times, most recently
from
2843af4 to
7db43ca
Compare
Contributor
Author
|
cl/627545431 is the test run re. procedure in go/flutter-fuchsia-pr-policy It is passing other than far_placeholder_test failures, which I think can be ignored for purposes of this PR, since the far_placeholder_test(s) are just making sure nobody actually merges a change that modifies the placeholder far files IIUC. |
dustingreen
force-pushed
the
route_sysmem2
branch
from
7db43ca to
026c587
Compare
dustingreen
changed the title
dustingreen
changed the title
Fuchsia's fake-display will be migrating to sysmem2, which requires fuchsia.sysmem2.Allocator to be routed in a few places. flutter/flutter#146858
dustingreen
force-pushed
the
route_sysmem2
branch
from
026c587 to
ae91af9
Compare
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/engine/52187, due to This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.
|
chinmaygarde
approved these changes
Apr 26, 2024
chinmaygarde
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 26, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 27, 2024
…147440) flutter/engine@c410180...bc05539 2024-04-26 [email protected] Roll Dart SDK from 9936bafe5eb1 to 919c7cab870b (1 revision) (flutter/engine#52407) 2024-04-26 [email protected] Delete errant back-tick in CONTRIBUTING.md (flutter/engine#52324) 2024-04-26 [email protected] [fuchsia] route fuchsia.sysmem2.Allocator (flutter/engine#52187) 2024-04-26 [email protected] [Impeller] clamp maximum glyph scale. (flutter/engine#52403) 2024-04-26 [email protected] Add markdown docs about RBE (flutter/engine#52394) 2024-04-26 [email protected] Roll Skia from 52083c205016 to 3401ef9641cc (5 revisions) (flutter/engine#52402) 2024-04-26 [email protected] Fix function type cast warnings for macOS embedder callbacks (flutter/engine#52377) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fuchsia's fake-display will be migrating to sysmem2, which requires fuchsia.sysmem2.Allocator to be routed in a few places.
fixes flutter/flutter#146858
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.