This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Only print "gclient sync" warning once during rebase #52133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Member
|
cc @zanderso |
jmagman
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 16, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 16, 2024
…146841) flutter/engine@bb127fe...4d69c0c 2024-04-16 [email protected] Only print "gclient sync" warning once during rebase (flutter/engine#52133) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gilnobrega
pushed a commit
to gilnobrega/flutter
that referenced
this pull request
Apr 22, 2024
…lutter#146841) flutter/engine@bb127fe...4d69c0c 2024-04-16 [email protected] Only print "gclient sync" warning once during rebase (flutter/engine#52133) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
zanderso
reviewed
Apr 22, 2024
| /// Prints a reminder to stdout to run `gclient sync -D`. Uses colors when | ||
| /// stdout supports ANSI escape codes. | ||
| void printGclientSyncReminder(String command) { | ||
| if (command == 'pre-rebase') { |
Member
There was a problem hiding this comment.
It would be cleaner to just remove the call to this function from https://github.com/flutter/engine/blob/main/tools/githooks/lib/src/pre_rebase_command.dart#L19, I think.
Member
Author
There was a problem hiding this comment.
Ah yes that would be better, let me fix it. Thanks @zanderso
auto-submit bot
pushed a commit
that referenced
this pull request
Apr 25, 2024
Remove `pre-rebase` check from `gclient sync` warning, and instead remove the warning call from `pre_rebase_command` Follow-up to #52133 (comment)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip the "pre-rebase" message since it will also be printed "post-checkout" at the end.
Fixes flutter/flutter#146781
Before this PR:
On this PR it's only printed once
Fixes flutter/flutter#146781