This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[iOS] allow enabling asserts from Plist. #52069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aam
approved these changes
Apr 15, 2024
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 16, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 16, 2024
…146792) flutter/engine@557ffb1...76fbe31 2024-04-16 [email protected] [Impeller] Update the readme to reflect current guidance on how to try Impeller. (flutter/engine#52135) 2024-04-16 [email protected] [iOS] allow enabling asserts from Plist. (flutter/engine#52069) 2024-04-16 [email protected] Roll Dart SDK from 3c2376cb9850 to 5f03197b9992 (5 revisions) (flutter/engine#52134) 2024-04-15 [email protected] Roll Skia from 0b5df0201734 to f6a2a2af83f1 (2 revisions) (flutter/engine#52136) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gilnobrega
pushed a commit
to gilnobrega/flutter
that referenced
this pull request
Apr 22, 2024
…lutter#146792) flutter/engine@557ffb1...76fbe31 2024-04-16 [email protected] [Impeller] Update the readme to reflect current guidance on how to try Impeller. (flutter/engine#52135) 2024-04-16 [email protected] [iOS] allow enabling asserts from Plist. (flutter/engine#52069) 2024-04-16 [email protected] Roll Dart SDK from 3c2376cb9850 to 5f03197b9992 (5 revisions) (flutter/engine#52134) 2024-04-15 [email protected] Roll Skia from 0b5df0201734 to f6a2a2af83f1 (2 revisions) (flutter/engine#52136) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of flutter/flutter#145729 .
I don't believe (or wasn't able to find ) if there is a way to specify dart-vm flags from an iOS application. Once its installed, the tool provided process args won't work. By allowing this to be specified in the Plist, developers can ensure the value persists for subsequent launches.