This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add additional dependencies to const_finder's pubspec.yaml #52033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Dart commit https://dart-review.googlesource.com/c/sdk/+/361781 added dependencies upon packages meta and _fe_analyzer_shared to the kernel package. Path overrides for these need to be added to the const_finder package in flutter/engine.
chinmaygarde
approved these changes
Apr 10, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 10, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 10, 2024
…146607) flutter/engine@91ba235...6f8ee9f 2024-04-10 [email protected] Manual roll ICU from a622de35ac31 to bad7ddbf9213 (7 revisions) (flutter/engine#52031) 2024-04-10 [email protected] Enable gtest-parallel for Impeller unit tests (flutter/engine#52004) 2024-04-10 [email protected] Add additional dependencies to const_finder's pubspec.yaml (flutter/engine#52033) 2024-04-10 [email protected] Roll Skia from 91e0c0f4bf41 to 5bbca5a30653 (3 revisions) (flutter/engine#52032) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gilnobrega
pushed a commit
to gilnobrega/flutter
that referenced
this pull request
Apr 22, 2024
…lutter#146607) flutter/engine@91ba235...6f8ee9f 2024-04-10 [email protected] Manual roll ICU from a622de35ac31 to bad7ddbf9213 (7 revisions) (flutter/engine#52031) 2024-04-10 [email protected] Enable gtest-parallel for Impeller unit tests (flutter/engine#52004) 2024-04-10 [email protected] Add additional dependencies to const_finder's pubspec.yaml (flutter/engine#52033) 2024-04-10 [email protected] Roll Skia from 91e0c0f4bf41 to 5bbca5a30653 (3 revisions) (flutter/engine#52032) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Dart commit https://dart-review.googlesource.com/c/sdk/+/361781 added dependencies upon packages meta and _fe_analyzer_shared to the kernel package. Path overrides for these need to be added to the const_finder package in flutter/engine.