This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Remove StC flag. #51992
Merged
[Impeller] Remove StC flag. #51992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I will follow-up with other cleanups to remove the old depth tracking and libtess. |
jonahwilliams
approved these changes
Apr 9, 2024
Contributor
jonahwilliams
left a comment
jonahwilliams
left a comment
There was a problem hiding this comment.
LGTM!
We do still have some code that is using libtess, so while we remove our usage of in the tessellator, there is a C folder that we should keep. vector_graphics is using that binary to do offline tessellation.
chinmaygarde
approved these changes
Apr 9, 2024
Member
chinmaygarde
left a comment
chinmaygarde
left a comment
There was a problem hiding this comment.
🎉
Adding visibility = [ ":*" ] to the tessellator component should help you shake out the uses of the tessellator and libtess.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 9, 2024
bdero
added a commit
that referenced
this pull request
Apr 9, 2024
Follow-up for #51992. This is now dead code.
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 9, 2024
…146527) flutter/engine@5dca50d...e4e2748 2024-04-09 [email protected] Roll Skia from 4281f51749b2 to a86861d21ae1 (23 revisions) (flutter/engine#51998) 2024-04-09 [email protected] [Impeller] Remove StC flag. (flutter/engine#51992) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
bdero
added a commit
that referenced
this pull request
Apr 11, 2024
Another clean-up patch following #51992. Also, don't rely on Entity tracked stencil height for clip coverage tracking.
gilnobrega
pushed a commit
to gilnobrega/flutter
that referenced
this pull request
Apr 22, 2024
…lutter#146527) flutter/engine@5dca50d...e4e2748 2024-04-09 [email protected] Roll Skia from 4281f51749b2 to a86861d21ae1 (23 revisions) (flutter/engine#51998) 2024-04-09 [email protected] [Impeller] Remove StC flag. (flutter/engine#51992) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is time.