[Impeller] ensure precision is matched between fragment and vertex stage for PowerVR GPU bug #51974
Conversation
…age for PowerVR GPU bug.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
chinmaygarde
left a comment
chinmaygarde
left a comment
There was a problem hiding this comment.
I don't understand why the frag stages have relaxed precision without a qualifier. We can make the compiler dump these decorations out and match them up at PSO creation time for an more bulletproof solution though.
This LGTM to fix the reported issue.
|
vertex stage is defaulting to highp, fragment stage to mediump |
|
Trying to switch what were originally fragment uniforms to varyings was a bit of a performance dead end. I think separately I'll refactor these back into fragment uniforms |
|
tested: malioc diff is a test (kind of) |
jonahwilliams
added
the
autosubmit
… vertex stage for PowerVR GPU bug (flutter/engine#51974)
…146477) flutter/engine@0226114...5a824e2 2024-04-09 [email protected] [Impeller] ensure precision is matched between fragment and vertex stage for PowerVR GPU bug (flutter/engine#51974) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…lutter#146477) flutter/engine@0226114...5a824e2 2024-04-09 [email protected] [Impeller] ensure precision is matched between fragment and vertex stage for PowerVR GPU bug (flutter/engine#51974) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2 participants
According to https://registry.khronos.org/vulkan/specs/1.3/html/vkspec.html#interfaces-iointerfaces-matching , we shouldn't have to do this, but alas. On the PowerVR GPU in the Samsung SM T220, precision mismatches are causing rendering problems.
Fix this by ensuring the precision matches.
Fixes flutter/flutter#143573