This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[et] Run GN before looking for targets. Default to build config targets #51956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matanlurey
approved these changes
Apr 8, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 8, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 8, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 8, 2024
…146463) flutter/engine@269aa69...8701a9a 2024-04-08 [email protected] Roll Fuchsia Linux SDK from RNSwTRpc6cfMY99CC... to 82nvjI_UGVS8qYqyH... (flutter/engine#51972) 2024-04-08 [email protected] Roll Dart SDK from f7239b3c25af to 28b5735ad7dc (4 revisions) (flutter/engine#51970) 2024-04-08 [email protected] [et] Run GN before looking for targets. Default to build config targets (flutter/engine#51956) 2024-04-08 [email protected] Run local_engine.json builds in prod (flutter/engine#51931) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from RNSwTRpc6cfM to 82nvjI_UGVS8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gilnobrega
pushed a commit
to gilnobrega/flutter
that referenced
this pull request
Apr 22, 2024
…lutter#146463) flutter/engine@269aa69...8701a9a 2024-04-08 [email protected] Roll Fuchsia Linux SDK from RNSwTRpc6cfMY99CC... to 82nvjI_UGVS8qYqyH... (flutter/engine#51972) 2024-04-08 [email protected] Roll Dart SDK from f7239b3c25af to 28b5735ad7dc (4 revisions) (flutter/engine#51970) 2024-04-08 [email protected] [et] Run GN before looking for targets. Default to build config targets (flutter/engine#51956) 2024-04-08 [email protected] Run local_engine.json builds in prod (flutter/engine#51931) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from RNSwTRpc6cfM to 82nvjI_UGVS8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the notes I left on #51868. Mainly fixes an issue in which the
build,query, andtestcommands would fail if GN had not yet been run for the requested configuration. Instead, in this PR, if the build output directory doesn't exist yet, then it will run GN before querying the targets.Additionally, for the
buildcommand, if no targets are specified on the command line, the PR uses the targets in the build config as the default rather than all targets.queryandtestkeep the same behavior.