This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] handle fill polylines with zero area. #51945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matanlurey
approved these changes
Apr 5, 2024
jonahwilliams
added
the
autosubmit
flutteractionsbot
pushed a commit
to flutteractionsbot/engine
that referenced
this pull request
Apr 5, 2024
Fixes flutter/flutter#146362 Sometimes we can have effectively zero area in a way that doesn't seem to register with the Skia bounding box logic we're using. Add a sanity check for zero points in the polyline.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 5, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 5, 2024
…146370) flutter/engine@48604df...b503915 2024-04-05 [email protected] Roll Skia from d596d9e4cb4f to d0f229153ae7 (2 revisions) (flutter/engine#51946) 2024-04-05 [email protected] [Impeller] handle fill polylines with zero area. (flutter/engine#51945) 2024-04-05 [email protected] [Windows] Move EGL surface creation (flutter/engine#51920) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gilnobrega
pushed a commit
to gilnobrega/flutter
that referenced
this pull request
Apr 22, 2024
…lutter#146370) flutter/engine@48604df...b503915 2024-04-05 [email protected] Roll Skia from d596d9e4cb4f to d0f229153ae7 (2 revisions) (flutter/engine#51946) 2024-04-05 [email protected] [Impeller] handle fill polylines with zero area. (flutter/engine#51945) 2024-04-05 [email protected] [Windows] Move EGL surface creation (flutter/engine#51920) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
jonahwilliams
added
the
cp: stable
Contributor
Author
|
I think this is the one we missed |
|
Failed to create CP due to merge conflicts. |
Contributor
Author
|
nope not this one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#146362
Sometimes we can have effectively zero area in a way that doesn't seem to register with the Skia bounding box logic we're using. Add a sanity check for zero points in the polyline.