Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@skia-flutter-autoroll
Copy link
Contributor

@skia-flutter-autoroll skia-flutter-autoroll force-pushed the dart-sdk-flutter-engine-b8491d30-8c08-4411-bb10-227bd09abd09-1712274298 branch from 981f089 to 692768f Compare April 4, 2024 23:45
@skia-flutter-autoroll skia-flutter-autoroll added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 4, 2024
@zanderso
Copy link
Member

zanderso commented Apr 5, 2024

Reason for revert: The previous Dart roll is blocking the roll of the engine to the framework. Unblocking the rolls depends on addressing flutter/flutter#146164.

@zanderso zanderso added the revert Label used to revert changes in a closed and merged pull request. label Apr 5, 2024
auto-submit bot pushed a commit that referenced this pull request Apr 5, 2024
@auto-submit auto-submit bot removed the revert Label used to revert changes in a closed and merged pull request. label Apr 5, 2024
auto-submit bot added a commit that referenced this pull request Apr 5, 2024
#51924)" (#51926)

Reverts: #51924
Initiated by: zanderso
Reason for reverting: The previous Dart roll is blocking the roll of the engine to the framework. Unblocking the rolls depends on addressing flutter/flutter#146164.
Original PR Author: skia-flutter-autoroll

Reviewed By: {fluttergithubbot}

This change reverts the following previous change:

https://dart.googlesource.com/sdk.git/+log/0ac840ba1f0b..31ddd6924103

2024-04-04 [email protected] Version 3.5.0-24.0.dev
2024-04-04 [email protected] Version 3.5.0-23.0.dev
2024-04-04 [email protected] Version 3.5.0-22.0.dev
2024-04-04 [email protected] Version 3.5.0-21.0.dev
2024-04-04 [email protected] Version 3.5.0-20.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 5, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 5, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Apr 5, 2024
…146322)

flutter/engine@d44462a...f17d586

2024-04-05 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Manual Dart roll to 0ac840ba1 and update frontend server snapshot filename (#51921)" (flutter/engine#51927)
2024-04-05 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from 0ac840ba1f0b to 31ddd6924103 (5 revisions) (#51924)" (flutter/engine#51926)
2024-04-05 [email protected] Roll Dart SDK from 0ac840ba1f0b to 31ddd6924103 (5 revisions) (flutter/engine#51924)
2024-04-04 [email protected] Manual Dart roll to 0ac840ba1 and update frontend server snapshot filename (flutter/engine#51921)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@skia-flutter-autoroll skia-flutter-autoroll deleted the dart-sdk-flutter-engine-b8491d30-8c08-4411-bb10-227bd09abd09-1712274298 branch April 11, 2024 23:46
gilnobrega pushed a commit to gilnobrega/flutter that referenced this pull request Apr 22, 2024
…lutter#146322)

flutter/engine@d44462a...f17d586

2024-04-05 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Manual Dart roll to 0ac840ba1 and update frontend server snapshot filename (flutter#51921)" (flutter/engine#51927)
2024-04-05 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from 0ac840ba1f0b to 31ddd6924103 (5 revisions) (flutter#51924)" (flutter/engine#51926)
2024-04-05 [email protected] Roll Dart SDK from 0ac840ba1f0b to 31ddd6924103 (5 revisions) (flutter/engine#51924)
2024-04-04 [email protected] Manual Dart roll to 0ac840ba1 and update frontend server snapshot filename (flutter/engine#51921)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants