Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@matanlurey
Copy link
Contributor

I didn't end up learning much from this, other than I wish JSON had macros.

*Just kidding, sort of.

@matanlurey matanlurey requested a review from zanderso April 3, 2024 22:08
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 3, 2024
@auto-submit auto-submit bot merged commit e279d00 into flutter:main Apr 3, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 4, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Apr 4, 2024
…146246)

flutter/engine@18fdcad...41da00a

2024-04-03 [email protected] [Impeller] cleanup auto usage in host_buffer (flutter/engine#51875)
2024-04-03 [email protected] Roll Skia from 82ae8ae5d3fb to fdbdb26b7029 (1 revision) (flutter/engine#51886)
2024-04-03 [email protected] Remove the bringup 20x emulator config. (flutter/engine#51885)
2024-04-03 [email protected] Roll Skia from 7d6dce620e46 to 82ae8ae5d3fb (2 revisions) (flutter/engine#51883)
2024-04-03 [email protected] [scenarios] Use adb to take screenshot, block on screenshot operation. (flutter/engine#51879)
2024-04-03 [email protected] Roll Dart SDK from 85adde7d4b5a to 5b812b9ec220 (2 revisions) (flutter/engine#51884)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants