This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Bump Robolectric to 4.12.1 #51800
Merged
Bump Robolectric to 4.12.1 #51800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: utzcoz <[email protected]>
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Signed-off-by: utzcoz <[email protected]>
Contributor
Author
gmackall
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/engine/51800, due to This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.
|
chinmaygarde
approved these changes
Apr 4, 2024
chinmaygarde
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 4, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 4, 2024
…146308) flutter/engine@e3104af...dcc99d6 2024-04-04 [email protected] Multiview backing store (flutter/engine#51722) 2024-04-04 [email protected] Roll Skia from f9dfb0308594 to 8ad03dfe4e2e (2 revisions) (flutter/engine#51915) 2024-04-04 [email protected] Bump Robolectric to 4.12.1 (flutter/engine#51800) 2024-04-04 [email protected] #145421 Fix glyph padding in STB atlas impl. (flutter/engine#51585) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gilnobrega
pushed a commit
to gilnobrega/flutter
that referenced
this pull request
Apr 22, 2024
…lutter#146308) flutter/engine@e3104af...dcc99d6 2024-04-04 [email protected] Multiview backing store (flutter/engine#51722) 2024-04-04 [email protected] Roll Skia from f9dfb0308594 to 8ad03dfe4e2e (2 revisions) (flutter/engine#51915) 2024-04-04 [email protected] Bump Robolectric to 4.12.1 (flutter/engine#51800) 2024-04-04 [email protected] flutter#145421 Fix glyph padding in STB atlas impl. (flutter/engine#51585) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/robolectric/robolectric/releases/tag/robolectric-4.12 and https://github.com/robolectric/robolectric/releases/tag/robolectric-4.12.1 .
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.