[Impeller] removed old blur detritus #51779
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
The license checker is going to complain at some point, maybe malioc too? Getting this into review since those are semi-automated diffs. |
chinmaygarde
left a comment
chinmaygarde
left a comment
There was a problem hiding this comment.
Nicely done. Really great!
gaaclarke
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/engine/51779, due to - The status or check suite Linux linux_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label. |
gaaclarke
added
the
autosubmit
…146014) flutter/engine@4b6836f...8ec35b6 2024-03-29 [email protected] [Impeller] removed old blur detritus (flutter/engine#51779) 2024-03-29 [email protected] Implement `Paint.from(other)` for `dart:ui`. (flutter/engine#51110) 2024-03-29 [email protected] Roll Dart SDK from bb65648e20e2 to 52b05146758e (3 revisions) (flutter/engine#51783) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
3 participants
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.