Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[CP] [canvaskit] Fall back to multi-context rendering on Firefox and Safari #51730

Closed
bc-lee wants to merge 2 commits into from
Closed

[CP] [canvaskit] Fall back to multi-context rendering on Firefox and Safari #51730

bc-lee wants to merge 2 commits into from

Conversation

@bc-lee
Copy link
Contributor

@bc-lee bc-lee commented Mar 27, 2024 •
edited by itsjustkevin
Loading

Cherry-pick request: flutter/flutter#145864
Cherry-pick of #49572

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added the platform-web Code specifically for the web engine label Mar 27, 2024
@bc-lee bc-lee marked this pull request as ready for review March 27, 2024 22:32
@bc-lee bc-lee mentioned this pull request Mar 27, 2024
Closed
@itsjustkevin
Copy link
Contributor

itsjustkevin commented Mar 27, 2024

@bc-lee please follow the cherry-pick instructions noted in the wiki.

@bc-lee
Copy link
Contributor Author

bc-lee commented Mar 28, 2024

@itsjustkevin Could you please inform me about the part of the instructions I might have missed? I've opened an issue for CP Request, and this CL is associated with it.

@itsjustkevin
Copy link
Contributor

itsjustkevin commented Mar 28, 2024

Oof, no part @bc-lee, I missed the cherry-pick request. My apologies.

@itsjustkevin itsjustkevin reopened this Mar 28, 2024
zanderso
zanderso suggested changes Apr 2, 2024
View reviewed changes
Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is not suitable for a cherry-pick at this stage of the release cycle.

@godofredoc godofredoc mentioned this pull request Apr 16, 2024
Merged
8 tasks
@bc-lee bc-lee deleted the cp-3.19-49572 branch April 23, 2024 16:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@zanderso zanderso zanderso requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

platform-web Code specifically for the web engine

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bc-lee @itsjustkevin @zanderso @harryterkelsen @godofredoc