This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Turn off internal retries for Android scenario app tests #51689
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
added
the
autosubmit
zanderso
changed the title
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 27, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 27, 2024
…145801) flutter/engine@92ebd47...d872d50 2024-03-27 [email protected] Roll Fuchsia Linux SDK from uu8lffXkeJQ9PC96I... to Lk8KBU-c97ROj-YHm... (flutter/engine#51690) 2024-03-26 [email protected] Turn off internal retries for Android scenario app tests (flutter/engine#51689) 2024-03-26 [email protected] Roll Skia from 1808016c7a6d to 23a5617e7f47 (1 revision) (flutter/engine#51688) 2024-03-26 [email protected] [macOS] Consolidate FlutterViewController static types/data (flutter/engine#51486) 2024-03-26 [email protected] Roll Skia from 0590062821dc to 1808016c7a6d (3 revisions) (flutter/engine#51686) 2024-03-26 [email protected] [iOS] remove arbitrary framerate cap. (flutter/engine#51663) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from uu8lffXkeJQ9 to Lk8KBU-c97RO If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Member
Author
|
@matanlurey I have not investigated, but after this change, the exclamation points in the relevant columns are now surfacing the flakes. |
Contributor
|
Great thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to make flakes more visible on the dashboard.