This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fail pre-submit if a negative image is encountered as part of goldctl imgtest add.
#51685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: gaaclarke <[email protected]>
mdebbar
approved these changes
Mar 27, 2024
matanlurey
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 27, 2024
…of `goldctl imgtest add`. (flutter/engine#51685)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 27, 2024
…145841) flutter/engine@00dab0d...b7dddee 2024-03-27 [email protected] Fail pre-submit if a negative image is encountered as part of `goldctl imgtest add`. (flutter/engine#51685) 2024-03-27 [email protected] [ios]ignore single edge pixel instead of rounding (flutter/engine#51687) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
9 tasks
Contributor
Author
|
Reason for revert: goldctl does not disambiguate negatives from untriaged images (see https://github.com/google/skia-buildbot/blob/9b9adad0805e6da96c4939cbd3d3855ab59998ee/gold-client/cmd/goldctl/cmd_imgtest_test.go#L325). |
matanlurey
added
the
revert
auto-submit
bot
removed
the
revert
auto-submit bot
added a commit
that referenced
this pull request
Mar 27, 2024
…f `goldctl imgtest add`. (#51685)" (#51718) Reverts: #51685 Initiated by: matanlurey Reason for reverting: goldctl does not disambiguate negatives from untriaged images (see https://github.com/google/skia-buildbot/blob/9b9adad0805e6da96c4939cbd3d3855ab59998ee/gold-client/cmd/goldctl/cmd_imgtest_test.go#L325). Original PR Author: matanlurey Reviewed By: {mdebbar, gaaclarke} This change reverts the following previous change: `flutter/engine`-side fix for flutter/flutter#145043. - Before this PR, if a negative image was encountered, we'd silently pass pre-submit, merge, and turn the tree red. - After this PR, a negative image both makes pre and post-submit red. Added tests, and fixed up some unrelated tests that were accidentally setting `pid` instead of `exitCode`. Oops! /cc @zanderso and @eyebrowsoffire (current engine sheriff).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flutter/engine-side fix for flutter/flutter#145043.Added tests, and fixed up some unrelated tests that were accidentally setting
pidinstead ofexitCode. Oops!/cc @zanderso and @eyebrowsoffire (current engine sheriff).