This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] revert usage of foreground blend optimization. #51679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jason-simmons
approved these changes
Mar 26, 2024
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
bdero
approved these changes
Mar 26, 2024
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 26, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 26, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 26, 2024
…145773) flutter/engine@b2d93a6...cffd1dc 2024-03-26 [email protected] Pass the flutter test font by default. (flutter/engine#51671) 2024-03-26 [email protected] [Impeller] revert usage of foreground blend optimization. (flutter/engine#51679) 2024-03-26 [email protected] [Impeller] Refactor clip stack into separate testable class. (flutter/engine#51656) 2024-03-26 [email protected] Roll buildroot to ba3ca696f4f95e998707523be755c15440c6bf3f (flutter/engine#51678) 2024-03-26 [email protected] Use RBE for Fuchsia CI builds (flutter/engine#51675) 2024-03-26 [email protected] Roll Skia from 7ffd936a66df to 90cfbf5fb91e (15 revisions) (flutter/engine#51677) 2024-03-26 [email protected] [macOS] Disable FlutterEngineTest.CanOverrideBackgroundColor (flutter/engine#51669) 2024-03-26 [email protected] Roll buildroot to 2a16784938d3be059014d4112f00ac70a386fa0c (flutter/engine#51674) 2024-03-26 [email protected] Roll Dart SDK from a783a4a043ec to 09e56db7d600 (2 revisions) (flutter/engine#51666) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submit bot
pushed a commit
that referenced
this pull request
Apr 5, 2024
…ptimization. (#51938) Reverted in #51679 due to flutter/flutter#144109 The foreground blend cases where using the coverage rect to determine the resulting position and UVs. this only worked if the CTM was scale translate, in rotation/skew/perspective cases the coverage rect is incorrect for choosing the texture coordinate position. Instead of positioning w/ coverage, use the snapshot transform which includes the scale/translation and correctly applies other transforms.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#144109
The Foreground blend optimization attempts to combine what would be a composited operation directly into the parent pass. Unfortunately, this doesn't work if the entity has a non scale/translate transform. Since we don't actually know the entities geometry, we've been using the coverage rect - but the coverage rect is always an axis aligned rectangle. So we can't use it to determine the actual geometry.