This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Transform geometry to safe depth ranges instead of forcing discrete depth values. #51673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdero
changed the title
bdero
changed the title
bdero
force-pushed
the
bdero/clip-depth-range
branch
from
6a66e8f to
40ab7f7
Compare
bdero
force-pushed
the
bdero/clip-depth-range
branch
from
f13b027 to
19cf165
Compare
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
|
Golden file changes are available for triage from new commit, Click here to view. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 27, 2024
…of forcing discrete depth values. (flutter/engine#51673)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 27, 2024
…of forcing discrete depth values. (flutter/engine#51673)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 27, 2024
…145851) flutter/engine@b7dddee...d656625 2024-03-27 [email protected] Add local paths for the Dart macros package, which is now a dependency of the analyzer package (flutter/engine#51709) 2024-03-27 [email protected] [Impeller] Transform geometry to safe depth ranges instead of forcing discrete depth values. (flutter/engine#51673) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves flutter/flutter#144333. (Specifically, this follow-up issue)
When drawing objects with a perspective transform, the rasterizer applies perspective correction for interpolated vertex attributes. By absorbing W and replacing Z with a discrete value, we were essentially removing all perspective information and disabling perspective correction.
Instead, we can manipulate the Entity transform to remap the output Z range to fit within the small depth slices that each Entity is allotted.
The golden draws a clip sandwich:
Before:
Screen.Recording.2024-03-25.at.10.51.30.PM.mov
After:
Screen.Recording.2024-03-25.at.10.46.43.PM.mov