Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Roll dart sdk to e6d7d67f4b35556805dd083fed15bf3ed41f7e33. #5165

Merged
aam merged 2 commits into from
May 3, 2018
Merged

Roll dart sdk to e6d7d67f4b35556805dd083fed15bf3ed41f7e33. #5165

aam merged 2 commits into from
May 3, 2018

Conversation

@aam
Copy link
Member

@aam aam commented May 3, 2018

Changes since last dart roll:

e6d7d67f4b Revert 4f18af12c7c6d53f02cf32cb9b5ea848b86e1d77 as it causes test breakages.
4877587346 [GN] Uses dart_action.gni instead of compiled_action.gni.
4b89ba24fb Meta CHANGELOG markdown cleanup.
3d688deba7 Bump analysis server version to 1.20.2
0dc81ae4eb Publish package:meta 1.1.5
7e54844fe7 [vm] Fix build for gcc 7.3.0.
9d10a6ad4a Issue 33034. Fix statement completion with missing condition right parenthesis.
3fd2d5fb05 [vm] Use compiler warnings to insist callers check for errors from Dart_Invoke*/Load*/Compile*.
afb490adbc [dart:io] Provide modern Dart-styled constants
2929b71aa2 [kernel/vm] Address follow-up review comments for bytecode generation
73768a5342 General TypeInfo and IdentifierContext cleanup
e93b2ee250 Improve typedef identifier recovery
46a9ed0617 Added example about calling a tear-off with a wrong-shape argument list
0c839cf3f8 [fasta] Add 'as' expressions to the Forest API
16f6ce2fee [release] Prepare changelog for 2.0.0-dev.53.0
d13bf49870 Check type-variable bounds on generic methods
794fe1e14f Add stacktrace tests for synchronous async
fb779df11c [frontend-server] Disable depfile test on Windows.

@aam
Roll dart sdk to e6d7d67.
3f48a8a 
Changes since last dart roll:

```
e6d7d67 Revert 4f18af1 as it causes test breakages.
4877587 [GN] Uses dart_action.gni instead of compiled_action.gni.
4b89ba2 Meta CHANGELOG markdown cleanup.
3d688de Bump analysis server version to 1.20.2
0dc81ae Publish package:meta 1.1.5
7e54844 [vm] Fix build for gcc 7.3.0.
9d10a6a Issue 33034. Fix statement completion with missing condition right parenthesis.
3fd2d5f [vm] Use compiler warnings to insist callers check for errors from Dart_Invoke*/Load*/Compile*.
afb490a [dart:io] Provide modern Dart-styled constants
2929b71 [kernel/vm] Address follow-up review comments for bytecode generation
73768a5 General TypeInfo and IdentifierContext cleanup
e93b2ee Improve typedef identifier recovery
46a9ed0 Added example about calling a tear-off with a wrong-shape argument list
0c839cf [fasta] Add 'as' expressions to the Forest API
16f6ce2 [release] Prepare changelog for 2.0.0-dev.53.0
d13bf49 Check type-variable bounds on generic methods
794fe1e Add stacktrace tests for synchronous async
fb779df [frontend-server] Disable depfile test on Windows.
```
@aam aam requested review from tvolkert and yjbanov May 3, 2018 21:22
@aam
Copy link
Member Author

aam commented May 3, 2018 •
edited
Loading

@zanderso does this failure look familiar, related to the change you landed in dart sdk?

gn gen --check in out/host_debug_unopt
ERROR at //flutter/lib/snapshot/BUILD.gn:260:1: Unknown function.
generate_entry_points_json_with_gen_snapshot("entry_points_json") {
^-------------------------------------------
See //flutter/BUILD.gn:11:5: which caused the file to be included.
    "$flutter_root/lib/snapshot:generate_snapshot_bin",
    ^-------------------------------------------------

@aam aam requested a review from zanderso May 3, 2018 21:55
zanderso
zanderso approved these changes May 3, 2018
View reviewed changes
Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aam aam merged commit 9e4c5d0 into flutter:master May 3, 2018
@aam aam deleted the roll-dart-20180503 branch May 3, 2018 22:05
jonahwilliams pushed a commit that referenced this pull request May 3, 2018
Revert "Roll dart sdk to e6d7d67. (#5165)"
750bc0c 
This reverts commit 9e4c5d0.
jonahwilliams pushed a commit that referenced this pull request May 3, 2018
Revert "Enables system chrome customization on Android O and greater" (…
3c583f8 
…#5167)

* Revert "Roll dart sdk to e6d7d67. (#5165)"

This reverts commit 9e4c5d0.

* Revert "Enables system chrome customization on Android M/O and greater (#5112)"

This reverts commit f2db5df.
sigurdm pushed a commit to sigurdm/engine that referenced this pull request May 4, 2018
@aam @sigurdm
Roll dart sdk to e6d7d67. (flutter#5165)
cff301b 
* Roll dart sdk to e6d7d67.

Changes since last dart roll:

```
e6d7d67 Revert 4f18af1 as it causes test breakages.
4877587 [GN] Uses dart_action.gni instead of compiled_action.gni.
4b89ba2 Meta CHANGELOG markdown cleanup.
3d688de Bump analysis server version to 1.20.2
0dc81ae Publish package:meta 1.1.5
7e54844 [vm] Fix build for gcc 7.3.0.
9d10a6a Issue 33034. Fix statement completion with missing condition right parenthesis.
3fd2d5f [vm] Use compiler warnings to insist callers check for errors from Dart_Invoke*/Load*/Compile*.
afb490a [dart:io] Provide modern Dart-styled constants
2929b71 [kernel/vm] Address follow-up review comments for bytecode generation
73768a5 General TypeInfo and IdentifierContext cleanup
e93b2ee Improve typedef identifier recovery
46a9ed0 Added example about calling a tear-off with a wrong-shape argument list
0c839cf [fasta] Add 'as' expressions to the Forest API
16f6ce2 [release] Prepare changelog for 2.0.0-dev.53.0
d13bf49 Check type-variable bounds on generic methods
794fe1e Add stacktrace tests for synchronous async
fb779df [frontend-server] Disable depfile test on Windows.
```

* Adjust gn-scripts to accommodate 4877587 refactoring.
sigurdm pushed a commit to sigurdm/engine that referenced this pull request May 4, 2018
@sigurdm
Revert "Enables system chrome customization on Android O and greater" (…
02cbaa9 
…flutter#5167)

* Revert "Roll dart sdk to e6d7d67. (flutter#5165)"

This reverts commit 9e4c5d0.

* Revert "Enables system chrome customization on Android M/O and greater (flutter#5112)"

This reverts commit f2db5df.
sigurdm pushed a commit to sigurdm/engine that referenced this pull request May 4, 2018
@aam @sigurdm
Roll dart sdk to e6d7d67. (flutter#5165)
40e59d6 
* Roll dart sdk to e6d7d67.

Changes since last dart roll:

```
e6d7d67 Revert 4f18af1 as it causes test breakages.
4877587 [GN] Uses dart_action.gni instead of compiled_action.gni.
4b89ba2 Meta CHANGELOG markdown cleanup.
3d688de Bump analysis server version to 1.20.2
0dc81ae Publish package:meta 1.1.5
7e54844 [vm] Fix build for gcc 7.3.0.
9d10a6a Issue 33034. Fix statement completion with missing condition right parenthesis.
3fd2d5f [vm] Use compiler warnings to insist callers check for errors from Dart_Invoke*/Load*/Compile*.
afb490a [dart:io] Provide modern Dart-styled constants
2929b71 [kernel/vm] Address follow-up review comments for bytecode generation
73768a5 General TypeInfo and IdentifierContext cleanup
e93b2ee Improve typedef identifier recovery
46a9ed0 Added example about calling a tear-off with a wrong-shape argument list
0c839cf [fasta] Add 'as' expressions to the Forest API
16f6ce2 [release] Prepare changelog for 2.0.0-dev.53.0
d13bf49 Check type-variable bounds on generic methods
794fe1e Add stacktrace tests for synchronous async
fb779df [frontend-server] Disable depfile test on Windows.
```

* Adjust gn-scripts to accommodate 4877587 refactoring.
sigurdm pushed a commit to sigurdm/engine that referenced this pull request May 4, 2018
@sigurdm
Revert "Enables system chrome customization on Android O and greater" (…
cf46462 
…flutter#5167)

* Revert "Roll dart sdk to e6d7d67. (flutter#5165)"

This reverts commit 9e4c5d0.

* Revert "Enables system chrome customization on Android M/O and greater (flutter#5112)"

This reverts commit f2db5df.
sigurdm pushed a commit to sigurdm/engine that referenced this pull request May 4, 2018
@aam @sigurdm
Roll dart sdk to e6d7d67. (flutter#5165)
3e30a0f 
* Roll dart sdk to e6d7d67.

Changes since last dart roll:

```
e6d7d67 Revert 4f18af1 as it causes test breakages.
4877587 [GN] Uses dart_action.gni instead of compiled_action.gni.
4b89ba2 Meta CHANGELOG markdown cleanup.
3d688de Bump analysis server version to 1.20.2
0dc81ae Publish package:meta 1.1.5
7e54844 [vm] Fix build for gcc 7.3.0.
9d10a6a Issue 33034. Fix statement completion with missing condition right parenthesis.
3fd2d5f [vm] Use compiler warnings to insist callers check for errors from Dart_Invoke*/Load*/Compile*.
afb490a [dart:io] Provide modern Dart-styled constants
2929b71 [kernel/vm] Address follow-up review comments for bytecode generation
73768a5 General TypeInfo and IdentifierContext cleanup
e93b2ee Improve typedef identifier recovery
46a9ed0 Added example about calling a tear-off with a wrong-shape argument list
0c839cf [fasta] Add 'as' expressions to the Forest API
16f6ce2 [release] Prepare changelog for 2.0.0-dev.53.0
d13bf49 Check type-variable bounds on generic methods
794fe1e Add stacktrace tests for synchronous async
fb779df [frontend-server] Disable depfile test on Windows.
```

* Adjust gn-scripts to accommodate 4877587 refactoring.
sigurdm pushed a commit to sigurdm/engine that referenced this pull request May 4, 2018
@sigurdm
Revert "Enables system chrome customization on Android O and greater" (…
1136a6c 
…flutter#5167)

* Revert "Roll dart sdk to e6d7d67. (flutter#5165)"

This reverts commit 9e4c5d0.

* Revert "Enables system chrome customization on Android M/O and greater (flutter#5112)"

This reverts commit f2db5df.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@yjbanov yjbanov Awaiting requested review from yjbanov

2 more reviewers

@zanderso zanderso zanderso approved these changes

@tvolkert tvolkert tvolkert approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aam @zanderso @tvolkert @googlebot