This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Embedder API] Fix test helper's present callback registration #51560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkwingsmt
approved these changes
Mar 21, 2024
Contributor
dkwingsmt
left a comment
dkwingsmt
left a comment
There was a problem hiding this comment.
LGTM.
I recommend not to add such code in the future until they're used anywhere. When there's code that is not tested (not even used) they can contain huge bugs like this. Incidents like this should be concerning.
Member
Author
This code is used and tested. However, the callbacks currently have identical behavior as the engine only supports a single view.
This comes off as unnecessarily harsh. |
loic-sharma
added
the
autosubmit
Contributor
|
My apology, I'll pay more attention to my wording. Blaming was not my intention. Especially since I also reviewed the original PR. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 21, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 21, 2024
…145569) flutter/engine@1b842ae...a46a7b2 2024-03-21 [email protected] [Fuchsia] Assert renders are only to the implicit view (flutter/engine#51559) 2024-03-21 [email protected] [Embedder API] Fix test helper's present callback registration (flutter/engine#51560) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#51293 added a new present callback that supports multiple views. However, the test helper incorrectly inversed the single-view and multi-view present callbacks. This didn't affect the existing tests as we don't any multi-view tests yet.
Prepares for flutter/flutter#144810
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.