Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@gmackall
Copy link
Member

@gmackall gmackall commented Mar 20, 2024

follow up to #51534 (comment)

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@gmackall gmackall requested a review from johnmccutchan March 20, 2024 15:53
@gmackall gmackall marked this pull request as ready for review March 20, 2024 15:56
@johnmccutchan johnmccutchan added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 20, 2024
@auto-submit auto-submit bot merged commit 8bd89b6 into flutter:main Mar 20, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 20, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 20, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Mar 20, 2024
…145491)

flutter/engine@1b52f57...d1fe899

2024-03-20 [email protected] Roll Skia from ecfbdc3df797 to 715a74e907d7 (2 revisions) (flutter/engine#51557)
2024-03-20 [email protected] Migrate use of deprecated GrDirectContext::MakeMetal (flutter/engine#51537)
2024-03-20 [email protected] Roll Dart SDK from 1fec62355504 to 0f00e7188e0e (1 revision) (flutter/engine#51556)
2024-03-20 [email protected] [Impeller] add test that demonstrates that VVL failures are fatal. (flutter/engine#51525)
2024-03-20 [email protected] Roll Skia from 4543913c6243 to ecfbdc3df797 (2 revisions) (flutter/engine#51555)
2024-03-20 [email protected] Upgrade to gradle 8.3 (flutter/engine#51422)
2024-03-20 [email protected] Add even more logging for UnsatisfiedLinkError (flutter/engine#51554)
2024-03-20 [email protected] Roll Skia from 80e713052b7a to 4543913c6243 (2 revisions) (flutter/engine#51553)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App platform-android

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants