This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Migrate use of deprecated GrDirectContext::MakeMetal #51537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
chinmaygarde
approved these changes
Mar 20, 2024
chinmaygarde
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 20, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 20, 2024
…145491) flutter/engine@1b52f57...d1fe899 2024-03-20 [email protected] Roll Skia from ecfbdc3df797 to 715a74e907d7 (2 revisions) (flutter/engine#51557) 2024-03-20 [email protected] Migrate use of deprecated GrDirectContext::MakeMetal (flutter/engine#51537) 2024-03-20 [email protected] Roll Dart SDK from 1fec62355504 to 0f00e7188e0e (1 revision) (flutter/engine#51556) 2024-03-20 [email protected] [Impeller] add test that demonstrates that VVL failures are fatal. (flutter/engine#51525) 2024-03-20 [email protected] Roll Skia from 4543913c6243 to ecfbdc3df797 (2 revisions) (flutter/engine#51555) 2024-03-20 [email protected] Upgrade to gradle 8.3 (flutter/engine#51422) 2024-03-20 [email protected] Add even more logging for UnsatisfiedLinkError (flutter/engine#51554) 2024-03-20 [email protected] Roll Skia from 80e713052b7a to 4543913c6243 (2 revisions) (flutter/engine#51553) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
hubot
pushed a commit
to google/skia
that referenced
this pull request
Mar 22, 2024
Follow-up to https://skia-review.googlesource.com/c/skia/+/826397 Client CLs: - flutter/engine#51537 - http://cl/617304072 - http://cl/617306119 Bug: b/293490566 Change-Id: Iec8e2fa301a3bc03ad205f79a25bc48e8ebfabc1 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/828878 Reviewed-by: Jim Van Verth <[email protected]> Reviewed-by: Robert Phillips <[email protected]> Commit-Queue: Kevin Lubick <[email protected]>
8 tasks
kjlubick
added a commit
that referenced
this pull request
Mar 22, 2024
In #51537 I missed one call to `GrDirectContext::MakeMetal` which is going away. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [ ] I listed at least one issue that this PR fixes in the description above. - [x] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests. - [ ] I updated/added relevant documentation (doc comments with `///`). - [x] I signed the [CLA]. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was deprecated in https://skia-review.googlesource.com/c/skia/+/826397. Furthermore, some metal files were relocated, so this changes those also.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.