This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[golden_test_harvester]: Put back sending the dimensions to the SkiaGoldClient #51536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matanlurey
approved these changes
Mar 20, 2024
Contributor
matanlurey
left a comment
matanlurey
left a comment
There was a problem hiding this comment.
I'm off for the rest of the week, was just checking in and happened to notice this.
LGTM, and thanks for fixing this properly (including a bit of a class re-design and adding a test) versus just hacking something together or reverting all of the changes - I really appreciate it!
| final bool dryRun = results['dry-run'] as bool; | ||
| if (dryRun) { | ||
| final bool isDryRun = results['dry-run'] as bool; | ||
| late Harvester harvester; |
Contributor
There was a problem hiding this comment.
Just make this just plain final Harvester harvester and rely on Dart understanding the basic if-statement (I believe), if not then late final.
| harvester = | ||
| await Harvester.create(workDirectory, io.stderr, | ||
| addImageToSkiaGold: _dryRunAddImg); | ||
| }else { |
Contributor
There was a problem hiding this comment.
nit: Space (soon dartfmt, soon)
| } | ||
|
|
||
| /// A [Harvester] that doesn't harvest, just logs to [stderr]. | ||
| class _VanillaHarvester implements Harvester { |
Contributor
There was a problem hiding this comment.
nit: Maybe just _DryRunHarvester (since that's it's purpose)
| }); | ||
| }); | ||
|
|
||
| test('client has dimensions', () async { |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 20, 2024
… the SkiaGoldClient (flutter/engine#51536)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 21, 2024
…145504) flutter/engine@98cfd92...912c61f 2024-03-20 [email protected] [golden_test_harvester]: Put back sending the dimensions to the SkiaGoldClient (flutter/engine#51536) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes flutter/flutter#145413
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.