This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add more logging for UnsatisfiedLinkError #51534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // cpu architecture. | ||
|
|
||
| String cpuArch = System.getProperty("os.arch"); | ||
| String[] nativeLibs = new File(flutterApplicationInfo.nativeLibraryDir).list(); |
Contributor
There was a problem hiding this comment.
should you filter this list down to just files that end with .so or change the message below on line 208?
Member
Author
There was a problem hiding this comment.
I'll change the message to the following files (I suppose I was assuming only .so files end up there because thats all I saw when I tested it, but that is probably a bad assumption)
johnmccutchan
approved these changes
Mar 19, 2024
gmackall
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/engine/51534, due to - The status or check suite Mac mac_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label. |
gmackall
added
the
autosubmit
| + " for more detail.\n" | ||
| + "App is using cpu architecture: " | ||
| + cpuArch | ||
| + ", and the native libraries directory contains the following files: " |
Contributor
There was a problem hiding this comment.
Can you include the native library directory path in this message? Or if the files in nativeLibs are absolute paths that no need to do that.
Member
Author
There was a problem hiding this comment.
Didn't see this before the merge, sorry. The files aren't shown as absolute paths, I'll put up a quick follow up to print the path too
8 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Mar 20, 2024
follow up to #51534 (comment) [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 20, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 20, 2024
…145479) flutter/engine@f803f2a...1b52f57 2024-03-20 [email protected] Add more logging for UnsatisfiedLinkError (flutter/engine#51534) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add additional logging for this error, because there are still no local reproduction cases.
related to flutter/flutter#144291
follow up to #50247
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.