This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] add test that demonstrates that VVL failures are fatal. #51525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Mar 19, 2024
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 20, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 20, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 20, 2024
…145491) flutter/engine@1b52f57...d1fe899 2024-03-20 [email protected] Roll Skia from ecfbdc3df797 to 715a74e907d7 (2 revisions) (flutter/engine#51557) 2024-03-20 [email protected] Migrate use of deprecated GrDirectContext::MakeMetal (flutter/engine#51537) 2024-03-20 [email protected] Roll Dart SDK from 1fec62355504 to 0f00e7188e0e (1 revision) (flutter/engine#51556) 2024-03-20 [email protected] [Impeller] add test that demonstrates that VVL failures are fatal. (flutter/engine#51525) 2024-03-20 [email protected] Roll Skia from 4543913c6243 to ecfbdc3df797 (2 revisions) (flutter/engine#51555) 2024-03-20 [email protected] Upgrade to gradle 8.3 (flutter/engine#51422) 2024-03-20 [email protected] Add even more logging for UnsatisfiedLinkError (flutter/engine#51554) 2024-03-20 [email protected] Roll Skia from 80e713052b7a to 4543913c6243 (2 revisions) (flutter/engine#51553) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#145118