This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[macOS] Consolidate FlutterViewController static types/data #51486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Contributor
|
test-exempt: code refactor with no semantic change Looks like you'll have to revert the consolidation part though; the thing you moved uses a declaration in the controller's private declaration section, but the controller's private declaration section uses a struct from the anonymous namespace. |
No semantic changes, just consolidates static functions in FlutterViewController.mm local to the translation unit into a single contiguous block at the top. Also includes two minor (non-semantic) changes: * Corrects static function naming to UpperCamelCase * Adds a mark to help highlight the static data/function block at the top of the file in Xcode.
cbracken
changed the title
cbracken
changed the title
cbracken
changed the title
cbracken
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 27, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 27, 2024
…145801) flutter/engine@92ebd47...d872d50 2024-03-27 [email protected] Roll Fuchsia Linux SDK from uu8lffXkeJQ9PC96I... to Lk8KBU-c97ROj-YHm... (flutter/engine#51690) 2024-03-26 [email protected] Turn off internal retries for Android scenario app tests (flutter/engine#51689) 2024-03-26 [email protected] Roll Skia from 1808016c7a6d to 23a5617e7f47 (1 revision) (flutter/engine#51688) 2024-03-26 [email protected] [macOS] Consolidate FlutterViewController static types/data (flutter/engine#51486) 2024-03-26 [email protected] Roll Skia from 0590062821dc to 1808016c7a6d (3 revisions) (flutter/engine#51686) 2024-03-26 [email protected] [iOS] remove arbitrary framerate cap. (flutter/engine#51663) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from uu8lffXkeJQ9 to Lk8KBU-c97RO If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No semantic changes, just consolidates static functions in FlutterViewController.mm local to the translation unit into a single contiguous block at the top.
Also includes three minor (non-semantic) changes:
OnKeyboardLayoutChangedPre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.