-
Notifications
You must be signed in to change notification settings - Fork 6k
Prefix non-local build config names with ci/ #51474
Conversation
9f33041 to
4f078ae
Compare
keyonghan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No recipes change should be expected. LGTM for configs change.
|
I'm fine with this as a temporary measure but I'd like to understand the plan to get us into a place where there is only one definition of each build config (aka out directory). |
There are a few different ways to accomplish that that we'll need to discuss. I would like to consider approaches where the exact contents and layout of I think maybe the spirit of your question is not exactly about the |
9f7136a to
2ce8e6f
Compare
…841) The relative path in the config file is incorrect if the working directory is not directly nested under `out/`, as will happen with flutter/engine#51474.
9f3fc0d to
b428642
Compare
b428642 to
b11d69a
Compare
…146055) flutter/engine@9689390...4f6b832 2024-03-31 [email protected] Prefix non-local build config names with ci/ (flutter/engine#51474) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Part 1 of flutter/flutter#145263
This PR updates the names of builds outside of
local_engine.jsonto be prefixed with the stringci/(orci\on Windows). For better or worse, the "name" field of a build is used to construct a path used as the source directory of a copy operation (I think the CAS archive step?). Because of that, changing the name of a build also requires updating the build output directory of the ninja build.This PR also adds tests to make sure the naming of these builds remains consistent.