This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add DisplayList Region and Transform benchmarks to CI #51429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
godofredoc
approved these changes
Mar 14, 2024
Contributor
godofredoc
left a comment
godofredoc
left a comment
There was a problem hiding this comment.
LGTM from the configurations point of view
Member
|
Reason for revert: Engine tree breakage |
bdero
added
the
revert
auto-submit bot
pushed a commit
that referenced
this pull request
Mar 14, 2024
This reverts commit 69f2920.
auto-submit
bot
removed
the
revert
auto-submit bot
added a commit
that referenced
this pull request
Mar 14, 2024
…" (#51432) Reverts: #51429 Initiated by: bdero Reason for reverting: Engine tree breakage ``` + /b/s/w/ir/cache/builder/src/out/host_release/display_list_region_benchmarks --benchmark_format=json /b/s/w/ir/cache/builder/src/flutter/testing/benchmark/generate_metrics.sh: line 17: /b/s/w/ir/cache/builder/src/out/host_release/display_list_region_benchmarks: No such file or directory ``` Original PR Author: flar Reviewed By: {godofredoc} This change reverts the following previous change: These benchmark results aren't shown in Skia perf because they were never added to the CI tasks to run.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 15, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 15, 2024
…145191) flutter/engine@622b372...995d890 2024-03-14 [email protected] Add some header-goodies for et. (flutter/engine#51434) 2024-03-14 [email protected] [Impeller] revert glyph atlas texture recycling. (flutter/engine#51428) 2024-03-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add DisplayList Region and Transform benchmarks to CI (#51429)" (flutter/engine#51432) 2024-03-14 [email protected] Add DisplayList Region and Transform benchmarks to CI (flutter/engine#51429) 2024-03-14 [email protected] Roll Dart SDK from 2bc8b222d01f to 70ca2323a702 (1 revision) (flutter/engine#51430) 2024-03-14 [email protected] Reduce code-duplication a bit and add more error context across `SkiaGoldClient`. (flutter/engine#51426) 2024-03-14 [email protected] [et] build and run commands disable RBE with a flag or when not available (flutter/engine#51404) 2024-03-14 [email protected] Fix flakiness in FlutterVSyncWaiterTest.VSyncWorks and FlutterDisplayLinkTest.WorkaroundForFB13482573 (flutter/engine#51405) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
flar
added a commit
to flar/engine
that referenced
this pull request
Mar 15, 2024
These benchmark results aren't shown in Skia perf because they were never added to the CI tasks to run.
flar
added a commit
to flar/engine
that referenced
this pull request
Mar 16, 2024
These benchmark results aren't shown in Skia perf because they were never added to the CI tasks to run.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These benchmark results aren't shown in Skia perf because they were never added to the CI tasks to run.