This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Remove always-true skia_enable_flutter_defines #51423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
approved these changes
Mar 14, 2024
zanderso
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 14, 2024
hubot
pushed a commit
to google/skia
that referenced
this pull request
Mar 14, 2024
Flutter maintains their own build rules [1] and defines [2] so these things do nothing anymore. Needs flutter/engine#51423 to land first [1] https://github.com/flutter/engine/blob/71dfa104e02cef3b8877171cff985c0d164800f0/skia/BUILD.gn [2] https://github.com/flutter/engine/blob/71dfa104e02cef3b8877171cff985c0d164800f0/skia/flutter_defines.gni Change-Id: I438f0f3b449f7e97c07d58abb007c3ab048b8e13 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/826398 Reviewed-by: Ben Wagner <[email protected]> Reviewed-by: Brian Osman <[email protected]>
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 15, 2024
…145179) flutter/engine@7b49dc9...622b372 2024-03-14 [email protected] [Impeller] revert round out. (flutter/engine#51395) 2024-03-14 [email protected] Remove always-true skia_enable_flutter_defines (flutter/engine#51423) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that Flutter owns the list of defines to add to Skia's build, we don't need to toggle it on or off. This allows Skia to delete the setting (https://skia-review.googlesource.com/c/skia/+/826398)
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.