Upgrade to gradle 8.3 #51422
Upgrade to gradle 8.3 #51422
Conversation
| <uses-permission android:name="android.permission.INTERNET" /> | ||
| <application | ||
| android:name="io.flutter.app.FlutterApplication" | ||
| android:allowBackup="false" |
There was a problem hiding this comment.
Removed because of a new lint that was triggered by the AGP upgrade. There were steps to migrate if the functionality was needed, but I'm not aware of why we would need this so I simply removed it.
| apply plugin: 'com.android.application' | ||
|
|
||
| android { | ||
| namespace 'dev.flutter.android_background_image' |
There was a problem hiding this comment.
This is the new way of setting this attribute (formerly it was defined in the manifest)
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
| } | ||
| dependencies { | ||
| classpath "com.android.tools.build:gradle:7.0.0" | ||
| classpath "com.android.tools.build:gradle:7.3.0" |
There was a problem hiding this comment.
No, this is the Android Gradle plugin version not the Gradle version
|
test-exempt: only change build system dependencies |
gmackall
added
the
autosubmit
…145491) flutter/engine@1b52f57...d1fe899 2024-03-20 [email protected] Roll Skia from ecfbdc3df797 to 715a74e907d7 (2 revisions) (flutter/engine#51557) 2024-03-20 [email protected] Migrate use of deprecated GrDirectContext::MakeMetal (flutter/engine#51537) 2024-03-20 [email protected] Roll Dart SDK from 1fec62355504 to 0f00e7188e0e (1 revision) (flutter/engine#51556) 2024-03-20 [email protected] [Impeller] add test that demonstrates that VVL failures are fatal. (flutter/engine#51525) 2024-03-20 [email protected] Roll Skia from 4543913c6243 to ecfbdc3df797 (2 revisions) (flutter/engine#51555) 2024-03-20 [email protected] Upgrade to gradle 8.3 (flutter/engine#51422) 2024-03-20 [email protected] Add even more logging for UnsatisfiedLinkError (flutter/engine#51554) 2024-03-20 [email protected] Roll Skia from 80e713052b7a to 4543913c6243 (2 revisions) (flutter/engine#51553) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2 participants
Fixes flutter/flutter#145165
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.