This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix flakiness in FlutterVSyncWaiterTest.VSyncWorks and FlutterDisplayLinkTest.WorkaroundForFB13482573 #51405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knopp
changed the title
3 tasks
knopp
changed the title
knopp
changed the title
loic-sharma
approved these changes
Mar 14, 2024
Member
loic-sharma
left a comment
loic-sharma
left a comment
There was a problem hiding this comment.
Thanks for following-up so quickly!
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 15, 2024
…terDisplayLinkTest.WorkaroundForFB13482573 (flutter/engine#51405)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 15, 2024
…145191) flutter/engine@622b372...995d890 2024-03-14 [email protected] Add some header-goodies for et. (flutter/engine#51434) 2024-03-14 [email protected] [Impeller] revert glyph atlas texture recycling. (flutter/engine#51428) 2024-03-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add DisplayList Region and Transform benchmarks to CI (#51429)" (flutter/engine#51432) 2024-03-14 [email protected] Add DisplayList Region and Transform benchmarks to CI (flutter/engine#51429) 2024-03-14 [email protected] Roll Dart SDK from 2bc8b222d01f to 70ca2323a702 (1 revision) (flutter/engine#51430) 2024-03-14 [email protected] Reduce code-duplication a bit and add more error context across `SkiaGoldClient`. (flutter/engine#51426) 2024-03-14 [email protected] [et] build and run commands disable RBE with a flag or when not available (flutter/engine#51404) 2024-03-14 [email protected] Fix flakiness in FlutterVSyncWaiterTest.VSyncWorks and FlutterDisplayLinkTest.WorkaroundForFB13482573 (flutter/engine#51405) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
cbracken
reviewed
Mar 18, 2024
Member
cbracken
left a comment
cbracken
left a comment
There was a problem hiding this comment.
Thanks for landing this -- apologies, out on holiday at the moment!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes potential source of flakiness where the tests assumes that scheduled block will be performed within certain time period, which, despite the tolerances may not be the case on test runner.
Ensures that
viewDidChangeWindownotification is not received while invalidating the displayLink and removing the display link view, which could deadlock at the end ofWorkaroundForFB13482573test because the notification would come whileFlutterDisplayLinkis in@synchronizedblock.If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.