This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Conditionally run golden_tests_harvester for run_impeller_golden_tests.
#51325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
approved these changes
Mar 11, 2024
Member
zanderso
left a comment
zanderso
left a comment
There was a problem hiding this comment.
LGTM on verifying that the client still runs in CI.
gaaclarke
reviewed
Mar 11, 2024
| # On release builds and local builds, we typically do not have GOLDCTL set, | ||
| # which on other words means that this invoking the SkiaGoldClient would | ||
| # throw. Skip this step in those cases and log a notice. | ||
| if 'GOLDCTL' not in os.environ: |
Member
There was a problem hiding this comment.
Can we add this to the golden tests harvester instead? Having to know about this environment at this level is kind of leaky. Someone has to consider its usage at 3 different levels ([run_tests, harvester, skia gold client]). It's best if it could be found in skiagoldclient, better if it could be in golden tests harvester, worst is adding knowledge about it here.
Contributor
Author
There was a problem hiding this comment.
We should add it to the harvester, but I think we have to answer flutter/flutter#144948. In other words, I think it's leaky/confusing behavior for the harvester to pretend to execute, and it's better to either (a) not run it at all, or (b) make not running explicit (i.e. --dry-run).
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 12, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 12, 2024
…ions) (#144996) Manual roll requested by [email protected] flutter/engine@6745955...6cefbe1 2024-03-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Move emscripten out of the buildroot into the flutter repo. (#51299)" (flutter/engine#51330) 2024-03-11 [email protected] Roll Skia from ff1eb5af6ce4 to 6f10903e2d28 (3 revisions) (flutter/engine#51326) 2024-03-11 [email protected] Conditionally run `golden_tests_harvester` for `run_impeller_golden_tests`. (flutter/engine#51325) 2024-03-11 [email protected] Roll Dart SDK from c3bd630e89bb to 09a1a1ede1c4 (1 revision) (flutter/engine#51324) 2024-03-11 [email protected] Move emscripten out of the buildroot into the flutter repo. (flutter/engine#51299) 2024-03-11 [email protected] Roll Skia from f8d5ecc7841d to ff1eb5af6ce4 (2 revisions) (flutter/engine#51322) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this restores the behavior prior to #50844 without making the client code faulty.
I'll file a follow-up issue, I don't think
golden_tests_harvestershould accept running ifGOLDCTLisn't set: flutter/flutter#144948./cc @godofredoc