This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Move emscripten out of the buildroot into the flutter repo. #51299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
matanlurey
approved these changes
Mar 9, 2024
auto-submit bot
pushed a commit
to flutter/buildroot
that referenced
this pull request
Mar 11, 2024
This changes the location the build files look for the emscripten toolchain. It is meant to go in alongside flutter/engine#51299 which actually changes the DEPS file to place emsdk in a different place.
eyebrowsoffire
added
the
autosubmit
zanderso
added a commit
that referenced
this pull request
Mar 11, 2024
The removal in #51299 appears to be confusing the engine -> framework autoroller.
zanderso
added
the
revert
Member
|
Reason for revert: Blocking the autoroller |
auto-submit
bot
removed
the
revert
auto-submit bot
added a commit
that referenced
this pull request
Mar 11, 2024
…51299)" (#51330) Reverts: #51299 Initiated by: zanderso Reason for reverting: Blocking the autoroller Original PR Author: eyebrowsoffire Reviewed By: {matanlurey} This change reverts the following previous change: This migrates the emscripten toolchain into the flutter repo, as well as the fonts for web unit tests. Also, removed the `web_dependencies` thing which is no longer used. This fixes flutter/flutter#143332 Depends on a buildroot change here: flutter/buildroot#833
auto-submit bot
added a commit
to flutter/buildroot
that referenced
this pull request
Mar 12, 2024
Reverts: #833 Initiated by: eyebrowsoffire Reason for reverting: corresponding change flutter/engine@6cefbe1 was reverted Original PR Author: eyebrowsoffire Reviewed By: {matanlurey} This change reverts the following previous change: This changes the location the build files look for the emscripten toolchain. It is meant to go in alongside flutter/engine#51299 which actually changes the DEPS file to place emsdk in a different place.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 12, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 12, 2024
…ions) (#144996) Manual roll requested by [email protected] flutter/engine@6745955...6cefbe1 2024-03-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Move emscripten out of the buildroot into the flutter repo. (#51299)" (flutter/engine#51330) 2024-03-11 [email protected] Roll Skia from ff1eb5af6ce4 to 6f10903e2d28 (3 revisions) (flutter/engine#51326) 2024-03-11 [email protected] Conditionally run `golden_tests_harvester` for `run_impeller_golden_tests`. (flutter/engine#51325) 2024-03-11 [email protected] Roll Dart SDK from c3bd630e89bb to 09a1a1ede1c4 (1 revision) (flutter/engine#51324) 2024-03-11 [email protected] Move emscripten out of the buildroot into the flutter repo. (flutter/engine#51299) 2024-03-11 [email protected] Roll Skia from f8d5ecc7841d to ff1eb5af6ce4 (2 revisions) (flutter/engine#51322) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migrates the emscripten toolchain into the flutter repo, as well as the fonts for web unit tests. Also, removed the
web_dependenciesthing which is no longer used.This fixes flutter/flutter#143332
Depends on a buildroot change here: flutter/buildroot#833