This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Windows] Move to new present callback #51293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Mar 14, 2024
Adds `FlutterCompositor.present_view_callback` to the embedder API. This new present callback adds a `view_id` member to allow embedders know which view is being presented. The embedder API does not allow embedders to create multiple views yet. This will be added in a future pull request. Design doc: https://flutter.dev/go/multi-view-embedder-apis Pull request that migrates the Windows embedder to this new embedder API: #51293 Part of flutter/flutter#144806 Part of flutter/flutter#142845 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
loic-sharma
force-pushed
the
windows_mv_present
branch
from
494faef to
4972ddf
Compare
loic-sharma
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 15, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 15, 2024
…145240) flutter/engine@ba1115c...2db915c 2024-03-15 [email protected] [Windows] Move to new present callback (flutter/engine#51293) 2024-03-15 [email protected] Log messages when an image successfully uploads to Skia Gold (flutter/engine#51455) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
8 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Mar 21, 2024
#51293 added a new present callback that supports multiple views. However, the test helper incorrectly inversed the single-view and multi-view present callbacks. This didn't affect the existing tests as we don't any multi-view tests yet. Prepares for flutter/flutter#144810 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates the Windows embedder to the new present callback which includes a
view_idvalue.Design doc: https://flutter.dev/go/multi-view-embedder-apis
Part of flutter/flutter#144810
Part of flutter/flutter#142845
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.