This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Disambiguate conditional expressions #51285
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internally, when targeting x86 Android, these files fail to compile:
The cause is that internally,
VULKAN_HPP_TYPESAFE_CONVERSIONis set but not for the GN build here. Copying from the vulkan docs:I'm not sure if doing the
static_caston theVK_NULL_HANDLEin this PR is right though. When targeting x86, this macro ends up being defined as0LL. But at the same time, putting the cast on the other ternary branch (e.g.static_cast<vk::Sampler>(immutable_sampler->GetSampler())) doesn't resolve the error.List which issues are fixed by this PR. You must list at least one issue.
b/328355475
Pre-launch Checklist
///).