This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Record restore clips in the replay mechanism when StC is enabled. #51259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
jonahwilliams
approved these changes
Mar 7, 2024
Contributor
jonahwilliams
left a comment
jonahwilliams
left a comment
There was a problem hiding this comment.
Nice LGTM
tested by way of benchmarks? I'd still ask for an exemption
Member
Author
|
Figured out a way to test this |
Contributor
|
nice |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 7, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 8, 2024
…144804) flutter/engine@1750693...80cd798 2024-03-07 [email protected] Roll buildroot to ef514ca5144ba0a4ce5e7075c325d24cd6da73a4 (flutter/engine#51265) 2024-03-07 [email protected] Roll Dart SDK from 4bc97350dc47 to 4c64fcc134bf (1 revision) (flutter/engine#51266) 2024-03-07 [email protected] [Impeller] Record restore clips in the replay mechanism when StC is enabled. (flutter/engine#51259) 2024-03-07 [email protected] Roll Skia from 6bfd57b8790f to 4a65dfcc70a5 (2 revisions) (flutter/engine#51263) 2024-03-07 [email protected] [gn] Disable running some python scripts from GN (flutter/engine#51248) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.