[gn] Disable running some python scripts from GN #51248
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
zanderso
force-pushed
the
disable-dart-gn-py
branch
from
b7c5c34 to
931fad3
Compare
|
So I understand correctly, adding the flags you did lets downstream code know not to run a script? |
Yes, that's correct. |
|
test-exempt: only visible by downstream GN rules, testing this isn't feasible. |
zanderso
added
the
autosubmit
…144804) flutter/engine@1750693...80cd798 2024-03-07 [email protected] Roll buildroot to ef514ca5144ba0a4ce5e7075c325d24cd6da73a4 (flutter/engine#51265) 2024-03-07 [email protected] Roll Dart SDK from 4bc97350dc47 to 4c64fcc134bf (1 revision) (flutter/engine#51266) 2024-03-07 [email protected] [Impeller] Record restore clips in the replay mechanism when StC is enabled. (flutter/engine#51259) 2024-03-07 [email protected] Roll Skia from 6bfd57b8790f to 4a65dfcc70a5 (2 revisions) (flutter/engine#51263) 2024-03-07 [email protected] [gn] Disable running some python scripts from GN (flutter/engine#51248) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
4 participants
For flutter/flutter#144430