Enables system chrome customization on Android O and greater #5112

jonahwilliams · 2018-04-27T16:56:47Z

remove log

cbracken · 2018-04-27T17:12:18Z

shell/platform/android/io/flutter/plugin/platform/PlatformPlugin.java

+        switch (style) {
+            case "SystemUiOverlayStyle.light":
+                window.setNavigationBarColor(0xffffffff);
+                flags |= 16;


Not sure what Android convention is, but personally bitwise operations read a lot clearer to me using hex literals.

cbracken · 2018-04-27T17:13:23Z

shell/platform/android/io/flutter/plugin/platform/PlatformPlugin.java

+                window.setNavigationBarColor(0xffffffff);
+                flags |= 16;
+                if ((flags & 16) == 0) {
+                    flags |= 16; //View.SYSTEM_UI_FLAG_LIGHT_NAVIGATION_BAR;


Is View.SYSTEM_UI_FLAG_LIGHT_NAVIGATION_BAR not available?

Not until we update our target SDK

…system_chrome

jonahwilliams · 2018-05-01T22:22:02Z

I've updated this PR based on offline discussion with @Hixie and @HansMuller.

Instead of just extending the dark and light theme to Android, we should allow users to customize all of the different system chrome related APIs. This PR works in tandem with https://github.com/flutter/flutter/pull/17171/files to extend the systemOverlayStyle with multiple values for the different parts of each platforms system chrome.

Currently on Android, versions less than 26 are not allowed to customize these settings from flutter since there are no "light" settings for the status or nav bar icons.

As a part of a later process, we'll remove the SystemChrome api calls from the app bar widgets and instead specify a theme-like way to customize system chrome. This is only intended to be a low-level API

HansMuller

LGTM

HansMuller · 2018-05-02T16:01:08Z

shell/platform/android/io/flutter/plugin/platform/PlatformPlugin.java

+                switch (navigationIconTheme) {
+                    case "SystemChromeTheme.dark":
+                        //View.SYSTEM_UI_FLAG_LIGHT_NAVIGATION_BAR;
+                        if ((flags & 0x10) == 0) {


This test and the similar tests below don't seem necessary?

My bit-fu is weak, but I believe this is necessary because we currently can set the same system chrome flag multiple times. If it is already on/off we don't want to toggle it again.

But x |= 0x10 doesn't toggle the bit, it just ensures that it's set. 0x10 | 0x10 == 0 | 0x10

Right, fixed

…and rename fields

jonahwilliams · 2018-05-03T00:26:20Z

Since this will require an engine roll and and a separate framework PR i'm going to wait until tomorrow when the build is hopefully green

HansMuller · 2018-05-03T20:20:02Z

shell/platform/android/io/flutter/plugin/platform/PlatformPlugin.java

+                            flags |= 0x10;
+                            break;
+                        case "Brightness.light":
+                            if ((flags & 0x10) == 0x10) {


Sorry for not bringing this up earlier. To unconditionally turn a bit off:

flags &= ~0x10;

#5112)" This reverts commit f2db5df.

…#5167) * Revert "Roll dart sdk to e6d7d67. (#5165)" This reverts commit 9e4c5d0. * Revert "Enables system chrome customization on Android M/O and greater (#5112)" This reverts commit f2db5df.

…er#5112)

…flutter#5167) * Revert "Roll dart sdk to e6d7d67. (flutter#5165)" This reverts commit 9e4c5d0. * Revert "Enables system chrome customization on Android M/O and greater (flutter#5112)" This reverts commit f2db5df.

…er#5112)

…flutter#5167) * Revert "Roll dart sdk to e6d7d67. (flutter#5165)" This reverts commit 9e4c5d0. * Revert "Enables system chrome customization on Android M/O and greater (flutter#5112)" This reverts commit f2db5df.

…er#5112)

…flutter#5167) * Revert "Roll dart sdk to e6d7d67. (flutter#5165)" This reverts commit 9e4c5d0. * Revert "Enables system chrome customization on Android M/O and greater (flutter#5112)" This reverts commit f2db5df.

Jonah Williams added 5 commits April 24, 2018 10:45

WIP first draft

88a7842

Merge branch 'master' of github.com:flutter/engine into system_chrome

e46de48

Merge branch 'master' of github.com:flutter/engine into system_chrome

2ee3d0f

make sure style is cached and bits are set correctly

b86ed30

swap light and dark colors

3eb3b73

googlebot added the cla: yes label Apr 27, 2018

Update PlatformPlugin.java

a93449b

remove log

cbracken reviewed Apr 27, 2018

View reviewed changes

Jonah Williams added 9 commits April 27, 2018 11:19

add missing mask, change numbers to hex, add comments for missing API

ca4f477

Merge branch 'system_chrome' of github.com:jonahwilliams/engine into …

89a9211

…system_chrome

make sure we dont destroy other flags

ee5c0ac

okay fix masking for real

ab3fd68

Merge branch 'master' of github.com:flutter/engine into system_chrome

9ef9fa8

Merge branch 'master' of github.com:flutter/engine into system_chrome

66b990a

update systemChromeAPI to take a json message

bea4eb7

fix error in iOS code

384df79

correct light and dark definitions

9f0f915

jonahwilliams mentioned this pull request May 1, 2018

Extend SystemUiOverlayStyle with additonal values for each platform flutter/flutter#17171

Merged

HansMuller approved these changes May 2, 2018

View reviewed changes

Jonah Williams added 4 commits May 2, 2018 10:21

change brightness switches to match expected framework documentation …

de9995b

…and rename fields

rename systemNavigationBarIconBrightness

c144d52

add back bit checks

4eb0e3e

remove or check

5d2f1ba

jonahwilliams changed the title ~~Enables dart & light system chrome on Android O and greater~~ Enables system chrome customization on Android O and greater May 3, 2018

update status bar changes to be allowed in N and O

4310e71

jonahwilliams merged commit f2db5df into flutter:master May 3, 2018

jonahwilliams deleted the system_chrome branch May 3, 2018 20:10

HansMuller reviewed May 3, 2018

View reviewed changes

jonahwilliams mentioned this pull request May 3, 2018

roll engine to f2db5dfd30f12407acab57f04acc8af7c6158891 flutter/flutter#17253

Closed

jonahwilliams pushed a commit that referenced this pull request May 3, 2018

Revert "Enables system chrome customization on Android M/O and greater (

880bfe1

#5112)" This reverts commit f2db5df.

jonahwilliams mentioned this pull request May 3, 2018

Revert "Enables system chrome customization on Android O and greater" #5167

Merged

jonahwilliams restored the system_chrome branch May 4, 2018 00:22

jonahwilliams mentioned this pull request May 4, 2018

Re-land Enables system chrome customization on Android O/N and greater #5171

Merged

sigurdm pushed a commit to sigurdm/engine that referenced this pull request May 4, 2018

Enables system chrome customization on Android M/O and greater (flutt…

20cd82c

…er#5112)

sigurdm pushed a commit to sigurdm/engine that referenced this pull request May 4, 2018

Enables system chrome customization on Android M/O and greater (flutt…

6560cf0

…er#5112)

sigurdm pushed a commit to sigurdm/engine that referenced this pull request May 4, 2018

Enables system chrome customization on Android M/O and greater (flutt…

3117718

…er#5112)

Enables system chrome customization on Android O and greater #5112

Enables system chrome customization on Android O and greater #5112

Uh oh!

Conversation

jonahwilliams commented Apr 27, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jonahwilliams commented May 1, 2018

Uh oh!

HansMuller left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

HansMuller May 2, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jonahwilliams commented May 3, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

HansMuller May 2, 2018 •

edited

Loading