[Impeller] test removal of submit batching. #51094
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
test-exempt: reverted change after checking benchmarks. |
jonahwilliams
added
the
autosubmit
…144416) flutter/engine@1f24eaa...bb6c6a0 2024-02-29 [email protected] [Impeller] test removal of submit batching. (flutter/engine#51094) 2024-02-29 [email protected] Use RBE for mac_clang_tidy (flutter/engine#51083) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
|
Preliminary results on the Pixel device: this slightly regressed avergae performance. The worst/99% may have gotten better though, so I will continue to monitor: |
3 participants
I have a feeling this is related to flutter/flutter#144371
Locally on the Pixel 4 (which is a similarish GPU, the batch submission is actually regressing performance).