This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Mark subpass framebuffer fetch tests as unsupported on GLES #50982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the GLES backend may claim the framebuffer fetch capability but its implementation does not support the multisample subpass input used in this test. Do not run this on GLES until there is clarification of the level of framebuffer fetch support intended for the GLES backend.
Member
|
Since there is a skip because of |
chinmaygarde
approved these changes
Feb 26, 2024
Member
Author
|
Filed flutter/flutter#144181 |
jason-simmons
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 28, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 29, 2024
…144345) flutter/engine@455c814...10331db 2024-02-28 [email protected] Roll Fuchsia Linux SDK from T1xAi_ww_mWEiDkVN... to ujOkbeYbrC8loPbfR... (flutter/engine#51066) 2024-02-28 [email protected] Roll abseil-cpp to 1db3bdd4eb208bef55c77f22aa94991e52225230 (flutter/engine#51062) 2024-02-28 [email protected] Roll Dart SDK from 7896a944fe67 to fdf4a62bd07b (1 revision) (flutter/engine#51064) 2024-02-28 [email protected] [Impeller] Mark subpass framebuffer fetch tests as unsupported on GLES (flutter/engine#50982) 2024-02-28 [email protected] Roll Skia from 93f245da0097 to 27171d6a9205 (1 revision) (flutter/engine#51063) 2024-02-28 [email protected] [Impeller] fix render pass depth descriptor. (flutter/engine#51031) 2024-02-28 [email protected] Make Skia object ostream operators work with unit tests (flutter/engine#51041) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from T1xAi_ww_mWE to ujOkbeYbrC8l If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the GLES backend may claim the framebuffer fetch capability but its implementation does not support the multisample subpass input used in this test. Do not run this on GLES until there is clarification of the level of framebuffer fetch support intended for the GLES backend.