This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Shift //third_party/icu to //flutter/third_party #50924
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
zanderso
changed the title
zanderso
force-pushed
the
move-more-deps
branch
from
c7061f7 to
7e85d25
Compare
matanlurey
approved these changes
Feb 23, 2024
zanderso
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 24, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 24, 2024
…144071) flutter/engine@ca24520...7380422 2024-02-23 [email protected] Roll Skia from 9d8d3f053775 to 45b38664b4ed (1 revision) (flutter/engine#50926) 2024-02-23 [email protected] Refactor Android `scenario_app` to remove shell entrypoint, simplify. (flutter/engine#50922) 2024-02-23 [email protected] [Windows] Add helper for headless integration tests (flutter/engine#50885) 2024-02-23 [email protected] Shift //third_party/icu to //flutter/third_party (flutter/engine#50924) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
|
This has caused https://autoroll.skia.org/r/icu-sdk-flutter-engine to start failing. Do we need to reconfigure or remove the roller? |
Member
Author
|
Yes. We need to reconfigure it. I don't remember where that config lives. Would you mind pinging it to an internal chat? Thanks for the heads up =) |
JSUYA
added a commit
to JSUYA/engine
that referenced
this pull request
May 31, 2024
Modify build script because the path to icu package path has been changed. flutter#50924
JSUYA
added a commit
to JSUYA/engine
that referenced
this pull request
Jun 13, 2024
Modify build script because the path to icu package path has been changed. flutter#50924
JSUYA
added a commit
to JSUYA/engine
that referenced
this pull request
Jul 22, 2024
Modify build script because the path to icu package path has been changed. flutter#50924
JSUYA
added a commit
to JSUYA/engine
that referenced
this pull request
Aug 23, 2024
Modify build script because the path to icu package path has been changed. flutter#50924
JSUYA
added a commit
to flutter-tizen/engine
that referenced
this pull request
Dec 18, 2024
Modify build script because the path to icu package path has been changed. flutter#50924
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For flutter/flutter#67373