This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Refactor Android scenario_app to remove shell entrypoint, simplify.
#50922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmackall
approved these changes
Feb 23, 2024
Member
gmackall
left a comment
gmackall
left a comment
There was a problem hiding this comment.
Looks like the out dir might still need adjusting but LGTM!
matanlurey
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 24, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 24, 2024
…144071) flutter/engine@ca24520...7380422 2024-02-23 [email protected] Roll Skia from 9d8d3f053775 to 45b38664b4ed (1 revision) (flutter/engine#50926) 2024-02-23 [email protected] Refactor Android `scenario_app` to remove shell entrypoint, simplify. (flutter/engine#50922) 2024-02-23 [email protected] [Windows] Add helper for headless integration tests (flutter/engine#50885) 2024-02-23 [email protected] Shift //third_party/icu to //flutter/third_party (flutter/engine#50924) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes flutter/flutter#144045.
There is still more work I want to do, like pulling args parsing into it's own class, and potentially cleanup the golden file collection, but those seem reasonable for future (lower priority) PRs.